]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
system: Don't execute Settings
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 31 Jul 2018 16:23:05 +0000 (13:23 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 31 Jul 2018 16:31:59 +0000 (13:31 -0300)
In a9ad91c831, a bug was introduced in the following code:

```c
            this._settingsAction.connect('clicked',
                                         this._onSettingsClicked().bind(this));
```

Notice that the callback is being executed! This commit
fixes that by removing the '()' from the callback.

js/ui/status/system.js

index 81b985c1f84c5b1a868cfb78a5dec7674781fe7f..c695f37be50d6d954dd5dc15c8e9f521686612d4 100644 (file)
@@ -269,7 +269,7 @@ var Indicator = new Lang.Class({
                                 app.get_name()];
             this._settingsAction = this._createActionButton(icon, name);
             this._settingsAction.connect('clicked',
-                                         this._onSettingsClicked().bind(this));
+                                         this._onSettingsClicked.bind(this));
         } else {
             log('Missing required core component Settings, expect trouble…');
             this._settingsAction = new St.Widget();